> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 24 April 2024 18.24 > > On Wed, 24 Apr 2024 11:29:51 +0100 > Ferruh Yigit <ferruh.yi...@amd.com> wrote: > > > On 4/24/2024 5:08 AM, Stephen Hemminger wrote: > > > For the 24.11 release, I want to remove the unused type string > argument > > > that shows up in rte_malloc() and related functions, then percolates > down > > > through. It was a idea in the 1.0 release of DPDK, never > implemented and > > > never removed. Yes it will cause API breakage, a large sweeping > change; > > > probably easily scripted with coccinelle. > > > > > > Maybe doing ABI version now? > > > > > > > Won't this impact many applications, is there big enough motivation to > > force many DPDK applications to update their code, living with it > looks > > simpler. > > > > Yeah, probably too big an impact but at least: > - change the documentation to say "do not use" should be NULL > - add script to remove all usage inside of DPDK > - get rid of places where useless arg is passed around inside > of the allocator internals.
For the sake of discussion: Do we want to get rid of the "name" parameter to the memzone allocation functions too? It's somewhat weird that they differ. Or are rte_memzone allocations considered init and control path, while rte_malloc allocations are considered fast path?
