On Tue, 7 May 2024 17:54:18 +0100 Ferruh Yigit <ferruh.yi...@amd.com> wrote:
> On 5/7/2024 5:00 PM, Morten Brørup wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Tuesday, 7 May 2024 16.51 > > > >> I would prefer that the SW statistics be handled generically by ethdev > >> layers and used by all such drivers. > > > > I agree. > > > > Please note that maintaining counters in the ethdev layer might cause more > > cache misses than maintaining them in the hot parts of the individual > > drivers' data structures, so it's not all that simple. ;-) > > > > Until then, let's find a short term solution, viable to implement across > > all software NIC drivers without API/ABI breakage. > > > > I am against ehtdev layer being aware of SW drivers and behave > differently for them. > This is dev_ops and can be managed per driver. We can add helper > functions for drivers if there is a common pattern. It is more about having a set of helper routines for SW only drivers. I have something in progress for this.