On 3. 6. 2024 16:40, Nicholas Pratte wrote:
I was able to use this implementation on the in-development jumboframes suite, setting restrictions on the required link speeds of NICs and using this as a requirement to run all test cases. While the framework you've developed is intuitive for true/false capabilities, this may not be the case for other device capabilities such as link speed, where perhaps someone might want to support a certain range of speeds (I also acknowledge that this may be a needless feature).
Would using the same decorator multiple times work? In any case, I will think about this.
And also, thanks for the comments in the other thread, I'll incorporate those.
I personally found implementing this to be a head-scratcher, and I ultimately ended up implementing this using a lower bound link speed instead of accepting a range of speeds. The reason for me implementing this at all is because of some complications within old DTS's jumboframes implementation. In old DTS, the test suite would check for 1GB NICs within certain test cases and modify the MTU lengths because of some inconsistent logic. You can see what I am referring to in the link below, take a look at test_jumboframes_bigger_jumbo, if you are interested. https://git.dpdk.org/tools/dts/tree/tests/TestSuite_jumboframes.py A solution to this problem is to set a restriction on the speed of NICs for the test suite, but whether or not this is a viable solution may require further discussion. This issue is its own conversation, but I'm bringing it up in this thread since we may run into requirements issues like this in the future, but I'm not so sure what the rest of you guys think, or if you guys think it is a viable concern at all.
