On 20/08/2024 16:54, Stephen Hemminger wrote:
> On Tue, 20 Aug 2024 14:42:56 +0100
> Alex Chapman <alex.chap...@arm.com> wrote:
>
>> Hi Stephen,
>>
>> I have gone through your patch series and the hexdump option would be
>> quite valuable for use in DTS.
>>
>> However I am currently facing the issue of distinguishing noise packets
>> from intentional packets within the verbose output. Prior to your patch,
>> the intention was to use the Layer 4 port to distinguish between them,
>> however with the hexdump option, the plan is to now use a custom payload.
>>
>> The one issue is that with verbose level 5 does not print the required
>> RSS hash and RSS queue information.
>
> The queue is there, in the output. Not sure if the hash matters.
> I wanted to keep to tshark format as much as possible.
>
We appreciate that but the RSS info is valuable to us. Seeing as
different enum values offer different info rather than different levels,
maybe we could change the enum to flags
+enum verbose_mode {
+ VERBOSE_OFF = 0,
+ VERBOSE_RX = 0x1,
+ VERBOSE_TX = 0x2,
+ VERBOSE_BOTH = 0x4,
+ VERBOSE_DISSECT = 0x8,
+ VERBOSE_HEX = 0x10
+};
Then the flags can be ORed together:
verbose_flags = VERBOSE_RX | VERBOSE_TX | VERBOSE_HEX | VERBOSE_RSS
And then instead of switch each print is an if that checks
for flag being set in the verbose_flags. This way you only get the RSS
if you request it.
