All looks great to me, thank you for the patch and addressing comments, there is just one comment that I left here about something that I missed pointing out on the previous version, but once that is addressed I think this will be ready.
On Fri, Aug 23, 2024 at 5:16 PM Dean Marx <dm...@iol.unh.edu> wrote: <snip> > + def send_packet_and_verify_insertion(self, expected_id: int) -> None: > + """Generate a packet with no vlan tag, send and verify on the dut. > + > + Args: > + expected_id: The vlan id that is being inserted through > tx_offload configuration. > + """ > + packet = Ether() / Raw(load="xxxxx") > + received_packets = self.send_packet_and_capture(packet) > + test_packet = None > + for packet in received_packets: > + if b"xxxxx" in packet.load: Sorry, it looks like I missed putting a comment on this conditional in my last review, but we should probably also put a hasattr() check in here as well. > + test_packet = packet > + break > + self.verify(test_packet is not None, "Packet was dropped when it > should have been received") > + if test_packet is not None: > + self.verify(test_packet.haslayer(Dot1Q), "The received packet > did not have a vlan tag") > + self.verify( > + test_packet.vlan == expected_id, "The received tag did not > match the expected tag" > + ) <snip> >
