On 23. 9. 2024 21:26, Jeremy Spewock wrote:
On Mon, Sep 23, 2024 at 11:02 AM Juraj Linkeš
<juraj.lin...@pantheon.tech> wrote:

Some test cases or suites may be testing a NIC feature that is not
supported on all NICs, so add support for marking test cases or suites
as requiring NIC capabilities.

The marking is done with a decorator, which populates the internal
required_capabilities attribute of TestProtocol. The NIC capability
itself is a wrapper around the NicCapability defined in testpmd_shell.
The reason is Enums cannot be extended and the class implements the
methods of its abstract base superclass.

The decorator API is designed to be simple to use. The arguments passed
to it are all from the testpmd shell. Everything else (even the actual
capability object creation) is done internally.

Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech>
Reviewed-by: Dean Marx <dm...@iol.unh.edu>

Thank you for addressing all my comments!

Thanks you for giving them. Very helpful.

Reviewed-by: Jeremy Spewock <jspew...@iol.unh.edu>

Reply via email to