> -----Original Message----- > From: Alexander Kozyrev <akozy...@nvidia.com> > Sent: Thursday, September 19, 2024 02:48 > To: dev@dpdk.org > Cc: Dariusz Sosnowski <dsosnow...@nvidia.com>; Ori Kam > <or...@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) > <tho...@monjalon.net>; Matan Azrad <ma...@nvidia.com>; > ferruh.yi...@amd.com; step...@networkplumber.org > Subject: [PATCH 3/6] ethdev: add flow rule insertion by index with pattern > > Add a new API to enqueue flow rule creation by index with pattern. > The new template table rules insertion type, index-based insertion with > pattern, requires a new flow rule creation function with both rule index and > pattern provided. > Packets will match on the provided pattern at the provided index. > > Signed-off-by: Alexander Kozyrev <akozy...@nvidia.com>
[snip] > +RTE_TRACE_POINT_FP( > + rte_flow_trace_async_create_by_index, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > + const struct rte_flow_op_attr *op_attr, > + const struct rte_flow_template_table *template_table, > + uint32_t rule_index, > + const struct rte_flow_action *actions, > + uint8_t actions_template_index, > + const void *user_data, const struct rte_flow *flow), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_ptr(op_attr); > + rte_trace_point_emit_ptr(template_table); > + rte_trace_point_emit_u32(rule_index); > + rte_trace_point_emit_ptr(actions); > + rte_trace_point_emit_u8(actions_template_index); > + rte_trace_point_emit_ptr(user_data); > + rte_trace_point_emit_ptr(flow); > +) This tracepoint is not used anywhere and is not related to the addition of rte_flow_trace_async_create_by_index_with_pattern. Maybe this tracepoint should be added in a separate commit? > +RTE_TRACE_POINT_FP( > + rte_flow_trace_async_create_by_index_with_pattern, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, > + const struct rte_flow_op_attr *op_attr, > + const struct rte_flow_template_table *template_table, > + uint32_t rule_index, > + const struct rte_flow_item *pattern, > + uint8_t pattern_template_index, > + const struct rte_flow_action *actions, > + uint8_t actions_template_index, > + const void *user_data, const struct rte_flow *flow), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u32(queue_id); > + rte_trace_point_emit_ptr(op_attr); > + rte_trace_point_emit_ptr(template_table); > + rte_trace_point_emit_u32(rule_index); > + rte_trace_point_emit_ptr(pattern); > + rte_trace_point_emit_u8(pattern_template_index); > + rte_trace_point_emit_ptr(actions); > + rte_trace_point_emit_u8(actions_template_index); > + rte_trace_point_emit_ptr(user_data); > + rte_trace_point_emit_ptr(flow); > +) This tracepoint is not used in this commit. Could you please add the usage? Best regards, Dariusz Sosnowski
