>-----Original Message-----
>From: Stephen Hemminger <[email protected]>
>Sent: Tuesday, October 8, 2024 6:11 AM
>To: Ankur Dwivedi <[email protected]>
>Cc: [email protected]; [email protected]; Jerin Jacob <[email protected]>
>Subject: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in
>checkpatch
>
>On Wed, 17 Jul 2024 12: 09: 53 +0000 Ankur Dwivedi
><adwivedi@ marvell. com> wrote: > >-----Original Message----- > >From: Ankur
>Dwivedi <adwivedi@ marvell. com> > >Sent: Friday, December 15, 2023 12: 14
>PM > >To:
>On Wed, 17 Jul 2024 12:09:53 +0000
>Ankur Dwivedi <[email protected]> wrote:
>
>> >-----Original Message-----
>> >From: Ankur Dwivedi <[email protected]>
>> >Sent: Friday, December 15, 2023 12:14 PM
>> >To: [email protected]
>> >Cc: [email protected]; Jerin Jacob Kollanukkaran
>> ><[email protected]>; Ankur Dwivedi <[email protected]>
>> >Subject: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch
>> >
>> >This patch series adds a validation in checkpatch tool to check if
>> >tracepoint is present in any new function added in ethdev, eventdev
>> >cryptodev and mempool library.
>>
>> Please let me know if this patch series can be merged in DPDK or if there are
>any comments.
>
>Not sure why the patch got ignored.
>Perhaps if check-tracepoint was run first against existing code; add to check-
>patch later.
check-tracepoint reads a patch and checks if a newly added function in a
library has the trace in it or not.
For existing code trace can be added manually. Trace was added for existing
functions in 23.03 release.
>
>And the skip list is empty, is that right?
Yes.
If trace is not required for a new library function, the function name can be
added in skiplist.
The checkpatch will ignore trace check for that function.
> is all of existing cryptodev ethdev ... ok
>now?
No, it's not completely ok. Few functions does not have trace added. Majority
have trace added.
