On Fri, 5 Jul 2024 09:31:11 +0000
Chengwen Feng <fengcheng...@huawei.com> wrote:
> When I was trying to debug a problem introduced by config.ini in
> test-dma-perf, I found the cfgfile library should enhance error
> detecting, so got this patchset.
>
> Chengwen Feng (4):
> cfgfile: remove dead code
> cfgfile: support verify name and value
> cfgfile: verify add section and entry result
> cfgfile: add strict parse flag
>
> ---
> v2: replace unique name with strict parse flag which address Stephen's
> comment.
>
> lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> lib/cfgfile/rte_cfgfile.h | 7 ++++
> 2 files changed, 59 insertions(+), 18 deletions(-)
>
This patch series is good, but a few things are needed still:
- please add a functional test for this.
- add a release note, since somebody might get be surprised.
Also, would be good to put DPDK cfgfile parser on the Wikipedia page
about ini files?
This library could really use some work:
- support variable length (not fixed size strings)
- support multi-line
- sub sections
- faster access for large ini files (not linked list)
