On 13-11-2024 22:18, David Marchand wrote:
Hello Hemant, On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal <[email protected]> wrote:The error handling is missing FQ unlock code. Detected by pvr-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might remain blocked. Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") Cc: [email protected] Signed-off-by: Hemant Agrawal <[email protected]>The fix looks good to me. To avoid regressions on this topic, could you look into enabling clang thread safety check? I suppose that FQLOCK and FQUNLOCK always come in pairs (seems a safe assumption), so enabling should be something like:
Thanks for the suggestion and code snippet. It looks good.
