Acked-by: Vladimir Medvedkin <[email protected]>
On 28/11/2024 01:53, Andre Muezerie wrote:
MSVC issues the warnings below:
1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)
The code would be better off by using 64 bit numbers to begin with.
That eliminates the need for a conversion to 64 bits later.
2) ../lib/hash/rte_thash.c(568): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)
1ULL should be used as the result of the bit shift gets multiplied
by sizeof(uint32_t).
Signed-off-by: Andre Muezerie <[email protected]>
---
lib/hash/rte_thash.c | 2 +-
lib/hash/rte_thash_gf2_poly_math.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
<snip>
--
Regards,
Vladimir