> -----Original Message-----
> From: Nawal Kishor <[email protected]>
> Sent: Monday, December 2, 2024 10:28 PM
> To: [email protected]; Nithin Kumar Dabilpuram <[email protected]>;
> Kiran Kumar Kokkilagadda <[email protected]>; Sunil Kumar Kori
> <[email protected]>; Satha Koteswara Rao Kottidi
> <[email protected]>; Harman Kalra <[email protected]>; Ashwin
> Sekhar T K <[email protected]>; Jerin Jacob <[email protected]>
> Cc: Nawal Kishor <[email protected]>
> Subject: [PATCH v2] common/cnxk: fix atomic load in batch ops
>
> In roc batch alloc wait code, __ATOMIC_RELAXED is changed to
> __ATOMIC_ACQUIRE in order to avoid potential out of order loads.
>
> Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll logic")
>
> Signed-off-by: Nawal Kishor <[email protected]>
Fixed the following issues and applied to dpdk-next-net-mrvl/for-main. Thanks
Is it candidate for Cc: [email protected] backport?
common/cnxk: fix atomic load in batch ops
Contributor name/email mismatch with .mailmap:
Nawal Kishor <[email protected]> is unknown in .mailmap
> ---
> v2: Fixed review comments
>
> drivers/common/cnxk/roc_npa.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h
> index f7cb4460e7..8525038810 100644
> --- a/drivers/common/cnxk/roc_npa.h
> +++ b/drivers/common/cnxk/roc_npa.h
> @@ -255,7 +255,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line,
> unsigned int wait_us)
> /* Batch alloc status code is updated in bits [5:6] of the first word
> * of the 128 byte cache line.
> */
> - while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) &
> 0x3) ==
> + while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) &
> 0x3) ==
> ALLOC_CCODE_INVAL)
> if (wait_us && (plt_tsc_cycles() - start) >= ticks)
> break;
> --
> 2.34.1
