Hi Thomas, The reason for removing RTE_NEXT_ABI here is caused by sink port, which is not wrapped by RTE_NEXT_ABI macro. If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original code will cause the compile error as pcap library is missing.
Regards, Fan -----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Friday, April 1, 2016 2:56 PM To: Zhang, Roy Fan <roy.fan.zhang at intel.com> Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up 2016-04-01 14:41, Fan Zhang: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -92,9 +92,7 @@ endif > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse > endif > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > _LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap > -endif Why removing NEXT_ABI here? The pcap port cannot work without it because of +#ifdef RTE_NEXT_ABI + + /** The full path of the pcap file to read packets from */ + char *file_name; + /** The number of bytes to be read from each packet in the + * pcap file. If this value is 0, the whole packet is read; + * if it is bigger than packet size, the generated packets + * will contain the whole packet */ + uint32_t n_bytes_per_pkt; + +#endif
