On Wed, Mar 12, 2025 at 04:29:40PM +0100, David Marchand wrote:
> On Wed, Mar 12, 2025 at 4:19 PM Bruce Richardson
> <bruce.richard...@intel.com> wrote:
> > > diff --git a/drivers/net/intel/ixgbe/meson.build
> > > b/drivers/net/intel/ixgbe/meson.build
> > > index 0ae12dd5ff..3553b0ffe1 100644
> > > --- a/drivers/net/intel/ixgbe/meson.build
> > > +++ b/drivers/net/intel/ixgbe/meson.build
> > > @@ -27,7 +27,7 @@ deps += ['hash', 'security']
> > > if arch_subdir == 'x86'
> > > sources += files('ixgbe_rxtx_vec_sse.c')
> > > sources += files('ixgbe_recycle_mbufs_vec_common.c')
> > > - if is_windows and cc.get_id() != 'clang'
> > > + if is_windows and cc.get_id() == 'gcc'
> > > cflags += ['-fno-asynchronous-unwind-tables']
> > > endif
> > > elif arch_subdir == 'arm'
> >
> > Out of interest I've just tried compiling up DPDK builds without these
> > unwind-tables flag, and they all pass, including the mingw build. This is
> > using:
> >
> > $ x86_64-w64-mingw32-gcc --version
> > x86_64-w64-mingw32-gcc (GCC) 13-win32
> > Copyright (C) 2023 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions. There is NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> >
> > Therefore, I wonder if we can just remove all these flags completely for
> > mingw now? They may only be needed for historical versions.
>
> Here is the original issue:
> https://inbox.dpdk.org/dev/cajfav8z3qfht9vv5xoplhi74byaht2ycfl2fflrmei4hfsg...@mail.gmail.com/
>
> It happened with mingw 8.1.0 apparently.
>
Thanks.
Given how new and unpolished windows support is generally, I don't believe
we should need to support many old versions of the mingw compiler. This is
especially true given the native windows build support that is being worked
on.
Looking at some CI logs[1], I believe mingw v10 is what is being used in the
CI. I might try doing a patch to remove these flags and see what the CI
makes of it. I'm not sure how many CI jobs in the various places (IOL lab,
Intel, etc.) do mingw testing, to really know what our min version is.
/Bruce
[1] https://github.com/ovsrobot/dpdk/actions/runs/13802361658/job/38606948026
