On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote: > A recent change broke disabling developer mode: > $ meson setup plop -Ddeveloper_mode=disabled > ... > drivers/meson.build:150:14: ERROR: Unknown variable "fs". > > Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers") > > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 8436d1dff8..dfb4cb3aee 100644 > --- a/meson.build > +++ b/meson.build > @@ -13,10 +13,11 @@ project('DPDK', 'c', > meson_version: '>= 0.57' > ) > > +fs = import('fs') > + > # check for developer mode > developer_mode = false > if get_option('developer_mode').auto() > - fs = import('fs') > developer_mode = fs.exists('.git') > else > developer_mode = get_option('developer_mode').enabled() > --
Simple fix, LGTM. Acked-by: Bruce Richardson <bruce.richard...@intel.com>