There is certain amount of duplication between different ixgbe, i40e, ice, and
iavf. This patchset specifically focuses on laying groundwork for deduplicating
the Rx side of things - providing common queue definitions, using common Rx
descriptor formats, and some low hanging fruit in terms of Rx code
deduplication, including vectorized implementations.
The first bunch of patches focus on small cleanups:
- variable renames
- definition renames
- using one definition for 16-byte descriptors instead per-driver
- fixing some cruft in IXGBE headers and source code
- refactoring of IXGBE vector code
- removing support for 16-byte descriptors from IAVF
Starting with patch 24 comes the meat of the patchset:
- creating common Rx queue structure
- unifying Rx rearm code to make use of new unified structures and definitions
- expanding Rx rearm code to have SSE, AVX2, and AVX512 implementations
At the end, there are a couple of patches that unify Rx and Tx mbuf recycle
for some drivers, but more work is needed on that front because we only touch
two drivers in each case - the others do have them, but they're implemented
differently from the ones that were deduplicated.
v5:
- Added refactors in IXGBE
- Addressed various bits of feedback
- Removed support for 16-byte descriptors from IAVF
v3 -> v4:
- Added a lot of cleanups to the patchset
- Moved to using unified Rx descriptor definitions
- Using a single compilation flag to support 16-byte descriptors
- Fixes for whitespace, syntax, etc.
Anatoly Burakov (34):
net/ixgbe: remove unused field in Rx queue struct
net/iavf: make IPsec stats dynamically allocated
net/ixgbe: match variable names to other drivers
net/i40e: match variable name to other drivers
net/ice: match variable name to other drivers
net/i40e: rename 16-byte descriptor define
net/ice: rename 16-byte descriptor define
net/iavf: remove 16-byte descriptor define
net/ixgbe: simplify packet type support check
net/ixgbe: adjust indentation
net/ixgbe: remove unnecessary platform checks
net/ixgbe: make context desc creation non-static
net/ixgbe: decouple scalar and vec rxq free mbufs
net/ixgbe: rename vector txq free mbufs
net/ixgbe: refactor vector common code
net/ixgbe: move vector Rx/Tx code to vec common
net/ixgbe: simplify vector PMD compilation
net/ixgbe: replace always-true check
net/ixgbe: add a desc done function
net/ixgbe: clean up definitions
net/i40e: clean up definitions
net/ice: clean up definitions
net/iavf: clean up definitions
net/ixgbe: create common Rx queue structure
net/i40e: use the common Rx queue structure
net/ice: use the common Rx queue structure
net/iavf: use the common Rx queue structure
net/intel: generalize vectorized Rx rearm
net/i40e: use common Rx rearm code
net/iavf: use common Rx rearm code
net/ixgbe: use common Rx rearm code
net/intel: support wider x86 vectors for Rx rearm
net/intel: add common Rx mbuf recycle
net/intel: add common Tx mbuf recycle
app/test-pmd/config.c | 4 +-
config/rte_config.h | 2 +-
doc/guides/nics/i40e.rst | 4 +-
drivers/net/intel/common/desc.h | 157 ++++++++
.../recycle_mbufs.h} | 94 +++--
drivers/net/intel/common/rx.h | 119 +++++-
drivers/net/intel/common/rx_vec_arm.h | 105 +++++
drivers/net/intel/common/rx_vec_ppc.h | 121 ++++++
drivers/net/intel/common/rx_vec_x86.h | 346 ++++++++++++++++
drivers/net/intel/i40e/i40e_ethdev.c | 4 +-
drivers/net/intel/i40e/i40e_ethdev.h | 4 +-
drivers/net/intel/i40e/i40e_fdir.c | 18 +-
drivers/net/intel/i40e/i40e_pf.c | 2 +-
.../i40e/i40e_recycle_mbufs_vec_common.c | 127 +-----
drivers/net/intel/i40e/i40e_rxtx.c | 194 ++++-----
drivers/net/intel/i40e/i40e_rxtx.h | 87 +---
drivers/net/intel/i40e/i40e_rxtx_common_avx.h | 215 ----------
.../net/intel/i40e/i40e_rxtx_vec_altivec.c | 135 ++-----
drivers/net/intel/i40e/i40e_rxtx_vec_avx2.c | 59 ++-
drivers/net/intel/i40e/i40e_rxtx_vec_avx512.c | 59 ++-
drivers/net/intel/i40e/i40e_rxtx_vec_common.h | 4 +-
drivers/net/intel/i40e/i40e_rxtx_vec_neon.c | 124 ++----
drivers/net/intel/i40e/i40e_rxtx_vec_sse.c | 130 ++----
drivers/net/intel/iavf/iavf.h | 4 +-
drivers/net/intel/iavf/iavf_ethdev.c | 13 +-
drivers/net/intel/iavf/iavf_rxtx.c | 269 ++++++-------
drivers/net/intel/iavf/iavf_rxtx.h | 178 +--------
drivers/net/intel/iavf/iavf_rxtx_vec_avx2.c | 92 ++---
drivers/net/intel/iavf/iavf_rxtx_vec_avx512.c | 85 ++--
drivers/net/intel/iavf/iavf_rxtx_vec_common.h | 219 +---------
drivers/net/intel/iavf/iavf_rxtx_vec_neon.c | 80 +---
drivers/net/intel/iavf/iavf_rxtx_vec_sse.c | 153 ++-----
drivers/net/intel/iavf/iavf_vchnl.c | 20 +-
drivers/net/intel/ice/ice_dcf.c | 7 +-
drivers/net/intel/ice/ice_dcf_ethdev.c | 27 +-
drivers/net/intel/ice/ice_ethdev.c | 2 +-
drivers/net/intel/ice/ice_ethdev.h | 4 +-
drivers/net/intel/ice/ice_rxtx.c | 222 +++++------
drivers/net/intel/ice/ice_rxtx.h | 92 +----
drivers/net/intel/ice/ice_rxtx_common_avx.h | 233 -----------
drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 45 +--
drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 53 ++-
drivers/net/intel/ice/ice_rxtx_vec_common.h | 6 +-
drivers/net/intel/ice/ice_rxtx_vec_sse.c | 125 ++----
drivers/net/intel/ixgbe/ixgbe_ethdev.c | 25 +-
drivers/net/intel/ixgbe/ixgbe_ipsec.c | 10 +-
drivers/net/intel/ixgbe/ixgbe_rxtx.c | 377 +++++++-----------
drivers/net/intel/ixgbe/ixgbe_rxtx.h | 108 +----
...x_vec_common.h => ixgbe_rxtx_vec_common.c} | 206 +++++-----
.../net/intel/ixgbe/ixgbe_rxtx_vec_common.h | 148 ++-----
drivers/net/intel/ixgbe/ixgbe_rxtx_vec_neon.c | 163 ++------
drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c | 176 ++------
drivers/net/intel/ixgbe/meson.build | 6 +-
53 files changed, 2090 insertions(+), 3172 deletions(-)
create mode 100644 drivers/net/intel/common/desc.h
rename drivers/net/intel/{ixgbe/ixgbe_recycle_mbufs_vec_common.c =>
common/recycle_mbufs.h} (60%)
create mode 100644 drivers/net/intel/common/rx_vec_arm.h
create mode 100644 drivers/net/intel/common/rx_vec_ppc.h
create mode 100644 drivers/net/intel/common/rx_vec_x86.h
delete mode 100644 drivers/net/intel/i40e/i40e_rxtx_common_avx.h
delete mode 100644 drivers/net/intel/ice/ice_rxtx_common_avx.h
copy drivers/net/intel/ixgbe/{ixgbe_rxtx_vec_common.h =>
ixgbe_rxtx_vec_common.c} (53%)
--
2.47.1
