Hi, Actually looks like we're going with another workaround, so I might not be needing my original patch. Also, I do not understand how my patch (not printing a log) makes a test fail - I couldn't find that test in DPDK to verify. I'm not that familiar though..
Yogev ________________________________ From: Maayan Kashani <mkash...@nvidia.com> Sent: Wednesday, June 4, 2025 10:02 To: Stephen Hemminger <step...@networkplumber.org>; Yogev Chaimovich <yo...@cgstowernetworks.com> Cc: Dariusz Sosnowski <dsosnow...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Bing Zhao <bi...@nvidia.com>; Ori Kam <or...@nvidia.com>; Suanming Mou <suanmi...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; dev@dpdk.org <dev@dpdk.org> Subject: RE: [PATCH] net/mlx5: fix transceiver warning when not exist Hi, Yogev, Thank you for contributing, Can you fix the failing CI TEST? https://patches.dpdk.org/project/dpdk/patch/20250506133107.4432-1-yo...@cgstowernetworks.com/ Regards, Maayan Kashani > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Tuesday, 20 May 2025 21:49 > To: Yogev Chaimovich <yo...@cgstowernetworks.com> > Cc: Dariusz Sosnowski <dsosnow...@nvidia.com>; Slava Ovsiienko > <viachesl...@nvidia.com>; Bing Zhao <bi...@nvidia.com>; Ori Kam > <or...@nvidia.com>; Suanming Mou <suanmi...@nvidia.com>; Matan > Azrad <ma...@nvidia.com>; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix transceiver warning when not exist > > External email: Use caution opening links or attachments > > > On Mon, 5 May 2025 12:14:51 +0000 > Yogev Chaimovich <yo...@cgstowernetworks.com> wrote: > > > From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 > 2001 > > From: yogev <yo...@cgstowernetworks.com> > > Date: Sun, 4 May 2025 23:11:46 +0300 > > Subject: [PATCH] net/mlx5: fix transceiver warning when not exist > > > > In case no transceiver exist when trying to get the transceiver's info > > There should not be an error message from the library. > > The caller may print an appropriate error message using the relevant > rte_errno if required. > > > > Signed-off-by: yogev <yo...@cgstowernetworks.com> > > Signed off by is a legal requirement and must use your full name. > As in: > Signed-off-by: Yogev Chaimovich <yo...@cgstowernetworks.com>
