Hi Stephen,
I will take care of it and resubmit.
Thanks
Sunil Kumar Kori
From: Stephen Hemminger <step...@networkplumber.org>
Sent: Tuesday, July 29, 2025 9:59 AM
To: Sunil Kumar Kori <sk...@marvell.com>
Cc: Shepard Siegel <shepard.sie...@atomicrules.com>; Ed Czeck
<ed.cz...@atomicrules.com>; John Miller <john.mil...@atomicrules.com>; Igor
Russkikh <irussk...@marvell.com>; Ajit Khaparde <ajit.khapa...@broadcom.com>;
Somnath Kotur <somnath.ko...@broadcom.com>; Nithin Kumar Dabilpuram
<ndabilpu...@marvell.com>; Kiran Kumar Kokkilagadda <kirankum...@marvell.com>;
Satha Koteswara Rao Kottidi <skotesh...@marvell.com>; Harman Kalra
<hka...@marvell.com>; Hemant Agrawal <hemant.agra...@nxp.com>; Sachin Saxena
<sachin.sax...@nxp.com>; John Daley <johnd...@cisco.com>; Hyong Youb Kim
<hyon...@cisco.com>; Jie Hai <haij...@huawei.com>; Ian Stokes
<ian.sto...@intel.com>; Bruce Richardson <bruce.richard...@intel.com>; Vladimir
Medvedkin <vladimir.medved...@intel.com>; Anatoly Burakov
<anatoly.bura...@intel.com>; Dariusz Sosnowski <dsosnow...@nvidia.com>;
Viacheslav Ovsiienko <viachesl...@nvidia.com>; Bing Zhao <bi...@nvidia.com>;
Ori Kam <or...@nvidia.com>; Suanming Mou <suanmi...@nvidia.com>; Matan Azrad
<ma...@nvidia.com>; Long Li <lon...@microsoft.com>; Wei Hu
<w...@microsoft.com>; Chaoyong He <chaoyong...@corigine.com>; Jiawen Wu
<jiawe...@trustnetic.com>; Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>;
Jerin Jacob <jer...@marvell.com>; Maciej Czekaj [C] <mcze...@marvell.com>; Jian
Wang <jianw...@trustnetic.com>; Maxime Coquelin <maxime.coque...@redhat.com>;
Chenbo Xia <chen...@nvidia.com>; Jochen Behrens <jochen.behr...@broadcom.com>;
Thomas Monjalon <tho...@monjalon.net>; Ferruh Yigit <ferruh.yi...@amd.com>;
dev@dpdk.org
Subject: [EXTERNAL] Re: [PATCH v2 1/2] ethdev: remove unnecessary type
conversion
On Mon, 12 May 2025 20: 37: 19 +0530 <skori@ marvell. com> wrote: > From: Sunil
Kumar Kori <skori@ marvell. com> > > As rte_eth_rx_queue_count() returns signed
value to represent > the error cases but internally invoked callback
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails:
Confirm sender and content safety before clicking links or opening attachments
Report Suspicious
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!tO3Z1f8UAnU6tQ_8mZxaDpsd9S1Slu0Hp4J3JKyA7OZCT6lylV5T0yFk--SXWH2bVATYaqk7jqFo_2iyTw$>
ZjQcmQRYFpfptBannerEnd
On Mon, 12 May 2025 20:37:19 +0530
<sk...@marvell.com<mailto:sk...@marvell.com>> wrote:
> From: Sunil Kumar Kori <sk...@marvell.com<mailto:sk...@marvell.com>>
>
> As rte_eth_rx_queue_count() returns signed value to represent
> the error cases but internally invoked callback is returning
> unsigned value. Hence unnecessary type conversion is done.
>
> To avoid this typecasting from signed to unsigned, fixed
> return type of callback functions.
>
> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com<mailto:sk...@marvell.com>>
> ---
> drivers/net/ark/ark_ethdev_rx.c | 2 +-
> drivers/net/ark/ark_ethdev_rx.h | 2 +-
> drivers/net/atlantic/atl_ethdev.h | 2 +-
> drivers/net/atlantic/atl_rxtx.c | 2 +-
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/cnxk/cnxk_ethdev.h | 2 +-
> drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +-
> drivers/net/dpaa/dpaa_ethdev.c | 2 +-
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> drivers/net/enic/enic_ethdev.c | 2 +-
> drivers/net/hns3/hns3_rxtx.c | 2 +-
> drivers/net/hns3/hns3_rxtx.h | 2 +-
> drivers/net/intel/e1000/e1000_ethdev.h | 4 ++--
> drivers/net/intel/e1000/em_rxtx.c | 2 +-
> drivers/net/intel/e1000/igb_rxtx.c | 2 +-
> drivers/net/intel/e1000/igc_txrx.c | 2 +-
> drivers/net/intel/e1000/igc_txrx.h | 2 +-
> drivers/net/intel/fm10k/fm10k.h | 2 +-
> drivers/net/intel/fm10k/fm10k_rxtx.c | 2 +-
> drivers/net/intel/i40e/i40e_rxtx.c | 2 +-
> drivers/net/intel/i40e/i40e_rxtx.h | 2 +-
> drivers/net/intel/iavf/iavf_rxtx.c | 2 +-
> drivers/net/intel/iavf/iavf_rxtx.h | 2 +-
> drivers/net/intel/ice/ice_rxtx.c | 2 +-
> drivers/net/intel/ice/ice_rxtx.h | 2 +-
> drivers/net/intel/ixgbe/ixgbe_ethdev.h | 2 +-
> drivers/net/intel/ixgbe/ixgbe_rxtx.c | 2 +-
> drivers/net/mlx5/mlx5_rx.c | 4 ++--
> drivers/net/mlx5/mlx5_rx.h | 2 +-
> drivers/net/netvsc/hn_rxtx.c | 2 +-
> drivers/net/netvsc/hn_var.h | 2 +-
> drivers/net/nfp/nfp_rxtx.c | 2 +-
> drivers/net/nfp/nfp_rxtx.h | 2 +-
> drivers/net/ngbe/ngbe_ethdev.h | 2 +-
> drivers/net/ngbe/ngbe_rxtx.c | 2 +-
> drivers/net/sfc/sfc_ethdev.c | 2 +-
> drivers/net/thunderx/nicvf_rxtx.c | 2 +-
> drivers/net/thunderx/nicvf_rxtx.h | 2 +-
> drivers/net/txgbe/txgbe_ethdev.h | 2 +-
> drivers/net/txgbe/txgbe_rxtx.c | 2 +-
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 +-
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-
> lib/ethdev/rte_ethdev.h | 2 +-
> lib/ethdev/rte_ethdev_core.h | 2 +-
> 45 files changed, 47 insertions(+), 47 deletions(-)
Was going to apply this for 25.11 (next-net).
But the Intel drivers got rearranged and no longer applies.
Would prefer that you rebase and resubmit, instead of me trying to patch a
patch for this.
