On 07/08/2025 15:07, Dean Marx wrote:
diff --git a/dts/tests/TestSuite_blocklist.py b/dts/tests/TestSuite_blocklist.py
index ce7da1cc8f..c75be247b5 100644
--- a/dts/tests/TestSuite_blocklist.py
+++ b/dts/tests/TestSuite_blocklist.py
@@ -12,7 +12,7 @@
  from framework.testbed_model.port import Port
-@requires(topology_type=TopologyType.two_links)
+@requires(topology_type=TopologyType.one_link)
  class TestBlocklist(TestSuite):
      """DPDK device blocklisting test suite."""
@@ -51,6 +51,7 @@ def one_port_blocklisted(self):
          """
          self.verify_blocklisted_ports(self.topology.sut_ports[:1])
+ @requires(topology_type=TopologyType.two_links)
I am guessing by the logic of this then one_port_blocklisted could also use it.> @func_test
      def all_but_one_port_blocklisted(self):
          """Run testpmd with all but one blocklisted port.
Would it make more sense to swap the order of the commits? This is because adding an explicit @requires for one_link becomes redundant. I'd probably change the default and then allow all the test suites that are happy with one link to just remove the two link requirement.

Reply via email to