20/08/2025 11:50, Dariusz Sosnowski: > There were 2 changes introduced in checkpatch.pl script [1][2] > which verify if Reported-by tag is followed by Link or Closes tag. > Example of the warning output: > > WARNING:BAD_REPORTED_BY_LINK: > Reported-by: should be immediately followed by Closes: > with a URL to the report > > Original purpose is to link the patch to the mailing list discussion > and/or a bug report. > > Since in DPDK these tags are not used, these warnings are false > positives and can be ignored in devtools/checkpatches.sh.
We use "Reported-by", it gives credit to people doing this precious work. But we don't mandate a link for this credit. > [1]: > https://github.com/torvalds/linux/commit/d7f1d71e5ef630ab9e15b5821d297a9e1a5fa1da > [2]: > https://github.com/torvalds/linux/commit/44c31888098a590b8ec5ba37009e5a983f7c4b46 > > Signed-off-by: Dariusz Sosnowski <dsosnow...@nvidia.com> > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 35037aa8f1..8c5b5d1380 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -33,7 +33,7 @@ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,STRLCPY,\ > PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ > LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL,BAD_REPORTED_BY_LINK" > options="$options $DPDK_CHECKPATCH_OPTIONS"
