Hi Vladimir,

On Sat, 30 Aug 2025, Vladimir Medvedkin wrote:

Hi all,

This series reworks the ethdev API related to advanced queueing configuration,
specifically Data Center Bridging (DCB) and Virtual Machine Device Queues
(VMDq). The existing API was designed years ago around ixgbe hardware
assumptions, which makes it difficult to properly support modern NICs and their
more flexible capabilities.


I like this overall.

The series seems to be a good rework, but the PMD changes are going to be vast.
Also, given the fact it targets the same release cycle as some new drivers do,
it can be problematic to apply 'rx_adv_conf.mq_mode' to, say, [1] on the go.

[1] https://mails.dpdk.org/archives/dev/2025-August/323562.html


Also, now we've touched on the topic of traffic classes and priorities, if I may
be so bold as to ask an unrelated question about [2]. Does the priority value
have to come specifically from VLAN header? Or can it come, say, from ToS of
IPv4, or Traffic Class of IPv6, or from some vendor-specific header?

[2] 
https://doc.dpdk.org/api-25.07/structrte__eth__pfc__conf.html#a0ad043071ccc7a261d79a759dc9c6f0c

Thank you.

Reply via email to