On Thu, 25 Sept 2025 at 15:05, David Marchand <[email protected]> wrote: > > The symbol check was implemented so far with shell scripts, relying > on objdump and other unix tools preventing it from being run on Windows. > > There was also an ask from some maintainers to convert this type of > developer checks to python scripts, to make it easier to extend and > maintain. > > The new implementation still performs the four consistency checks: > - symbols exported as experimental but missing __rte_experimental flag, > - symbols flagged as experimental but missing export declaration, > - symbols exported as internal but missing __rte_internal flag, > - symbols flagged as internal but missing export declaration, > > The initial implementation was done relying on Claude Code > (asking it to reimplement the existing check after it analysed > the current build flow). > > I then cleaned up the python script, removed dumb comments, fixed coding > style, fixed MAINTAINERS, fixed some dumb issues (like definition order in > buildtools/meson.build).
Looks like trusting Claude on the python subtleties was not a good idea. A v2 will be needed, but this change can wait to have a real user. I'll mark as changes requested in patchwork. -- David Marchand
