Hey Akhil, I pushed a reworked v2 patch based on the comments below: https://patches.dpdk.org/project/dpdk/list/?series=36288
Even though I included --in-reply-to to the older series it seems to have created a new series. Is that expected or is the command I used incorrect? The command I used was: git send-email --to-cmd ./devtools/get-maintainer.sh --cc [email protected] --thread --no-chain-reply-to [email protected] *.patch Thanks Sameer Vaze ________________________________ From: Akhil Goyal <[email protected]> Sent: Friday, October 3, 2025 1:27 AM To: Sameer Vaze <[email protected]>; Fan Zhang <[email protected]>; Ashish Gupta <[email protected]> Cc: [email protected] <[email protected]> Subject: RE: [EXTERNAL] [PATCH 1/3] compressdev: support for dictionaries and PDCP checksum WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. > Sorry for the various series I pushed. I attempted in reply to but it seemed > to > create a new series. If I am making changes to one commit in a series, do I > need > to resend all commits with an updated version? In such a case do I reply to > the > series or the specific change I am updating? Yes reply to the series. And all patches need to be resent. > > Regarding the comments on adding UDC as a new algo: UDC uses raw deflate and > is not a separate algo in itself. Support for pre defined dictionaries is > already > supported by zlib and is not UDC specific per se. > In that case also, these new params in xform should be part of alg specific params - rte_comp_deflate_params. Please note: we need to close the RC1 by 5th Oct. Please send the rework asap. Thanks.
