On Wed, Oct 01, 2025 at 10:46:22AM +0200, David Marchand wrote: > On Tue, 30 Sept 2025 at 17:13, Bruce Richardson > <[email protected]> wrote: > > > It seems this comment got lost. > > > > > > Options don't change that often, but I would prefer we point at the > > > right release doc, rather than origin/main. > > > What do you think of: > > > > > > @@ -164,11 +164,17 @@ eal_usage(const struct rte_argparse *obj) > > > }, > > > #define STR_ALIAS STR_ARG > > > > > > +#if RTE_VER_RELEASE == 99 > > > +#define DOC_SUFFIX "-" RTE_STR(RTE_VER_MAJOR) > > > +#else > > > +#define DOC_SUFFIX > > > +#endif > > > + > > > struct rte_argparse eal_argparse = { > > > .prog_name = "", > > > .usage = "<DPDK EAL options> -- <App options>", > > > .epilog = "For more information on EAL options, see the DPDK > > > documentation at: \n" > > > - "\thttps://doc.dpdk.org/guides/"; > > > RTE_EXEC_ENV_NAME "_gsg/", > > > + "\thttps://doc.dpdk.org/guides"; DOC_SUFFIX "/" > > > RTE_EXEC_ENV_NAME "_gsg/", > > > > > Yes, that can work, though RTE_VER_MAJOR doesn't exist that I can see. Will > > rework it a bit. > > Ah sorry, it was in my previous comment: > https://inbox.dpdk.org/dev/cajfav8y5_o3t6hlbzov0lqhxyau2s_n0p3c3y+wsgvujd8g...@mail.gmail.com/ > Ah, ok, sorry I missed the comment the first time. I've implemented this without RTE_MAJOR for now anyway.
/Bruce
