From: Sangtani Parag Satishbhai <[email protected]>
Now as the mpc is initialized for P7 platform regardless
of mpc=1 devarg, RTE and bnxt argument processing APIs
for mpc devarg are redundant. This patch removes such RTE
and bnxt APIs. The "mpc=1" devarg is now invalid and should
not be used while launching an application.
Before:
./dpdk-testpmd -c 0xff -a 0000:0a:00.0,mpc=1,app-id=0
After:
./dpdk-testpmd -c 0xff -a 0000:0a:00.0,app-id=0
Signed-off-by: Sangtani Parag Satishbhai
<[email protected]>
Reviewed-by: Ajit Khaparde <[email protected]>
---
drivers/net/bnxt/bnxt.h | 3 ---
drivers/net/bnxt/bnxt_ethdev.c | 19 ++++---------------
2 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 90352d537c..83ae151066 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -854,9 +854,6 @@ struct bnxt {
((bp)->flags2 & BNXT_FLAGS2_MULTIROOT_EN)
#define BNXT_FLAGS2_COMPRESSED_RX_CQE BIT(5)
-#define BNXT_FLAGS2_USE_MPC BIT(6)
-#define BNXT_USE_MPC(bp) \
- ((bp)->flags2 & BNXT_FLAGS2_USE_MPC)
#define BNXT_FLAGS2_REP_MODE BIT(7)
#define BNXT_REP_MODE_EN(bp) \
((bp)->flags2 & BNXT_FLAGS2_REP_MODE)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c92e335a51..854c8b7371 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -152,11 +152,6 @@ static const struct rte_eth_speed_lanes_capa
speed_lanes_capa_tbl[] = {
*/
#define BNXT_DEVARG_CQE_MODE_INVALID(val) ((val) > 1)
-/*
- * mpc = an non-negative 8-bit number
- */
-#define BNXT_DEVARG_MPC_INVALID(val) ((val) > 1)
-
/*
* app-id = an non-negative 8-bit number
*/
@@ -207,7 +202,6 @@ static const struct rte_eth_speed_lanes_capa
speed_lanes_capa_tbl[] = {
#define BNXT_DEVARG_REP_FC_F2R_INVALID(rep_fc_f2r) ((rep_fc_f2r) > 1)
int bnxt_cfa_code_dynfield_offset = -1;
-unsigned long mpc;
/*
* max_num_kflows must be >= 32
@@ -1759,8 +1753,7 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev)
/* Process any remaining notifications in default completion queue */
bnxt_int_handler(eth_dev);
- if (mpc != 0)
- bnxt_mpc_close(bp);
+ bnxt_mpc_close(bp);
bnxt_shutdown_nic(bp);
bnxt_hwrm_if_change(bp, false);
@@ -1856,11 +1849,9 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
if (rc)
goto error;
- if (mpc != 0) {
- rc = bnxt_mpc_open(bp);
- if (rc != 0)
- PMD_DRV_LOG_LINE(DEBUG, "MPC open failed");
- }
+ rc = bnxt_mpc_open(bp);
+ if (rc != 0)
+ PMD_DRV_LOG_LINE(DEBUG, "MPC open failed");
rc = bnxt_alloc_prev_ring_stats(bp);
if (rc)
@@ -7213,8 +7204,6 @@ static bool bnxt_enable_ulp(struct bnxt *bp)
/* not enabling ulp for cli and no truflow apps */
if (BNXT_TRUFLOW_EN(bp) && bp->app_id != 254 &&
bp->app_id != 255) {
- if (BNXT_CHIP_P7(bp) && !mpc)
- return false;
return true;
}
return false;
--
2.39.5 (Apple Git-154)
