[PATCH v4 13/14] app/dma-perf: fix wrong stage to stop dmadev

[Chengwen Feng]

The benchmark do stop-dmadev at last, it has two problem:
1. it still invoke stop-dmadev when something wrong before
   config-dmadev.
2. the dmadev may working but the memory are freed.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng <fengcheng...@huawei.com>
---
 app/test-dma-perf/benchmark.c | 36 +++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
index 4ce95d0f7b..7512018e38 100644
--- a/app/test-dma-perf/benchmark.c
+++ b/app/test-dma-perf/benchmark.c
@@ -268,6 +268,25 @@ config_dmadevs(struct test_configure *cfg)
        return 0;
 }
 
+static void
+stop_dmadev(struct test_configure *cfg, bool *stopped)
+{
+       struct lcore_dma_map_t *lcore_dma_map;
+       uint32_t i;
+
+       if (*stopped)
+               return;
+
+       if (cfg->test_type == TEST_TYPE_DMA_MEM_COPY) {
+               for (i = 0; i < cfg->num_worker; i++) {
+                       lcore_dma_map = &cfg->dma_config[i].lcore_dma_map;
+                       printf("Stopping dmadev %d\n", lcore_dma_map->dma_id);
+                       rte_dma_stop(lcore_dma_map->dma_id);
+               }
+       }
+       *stopped = true;
+}
+
 static void
 error_exit(int dev_id)
 {
@@ -880,6 +899,7 @@ mem_copy_benchmark(struct test_configure *cfg)
        float bandwidth, bandwidth_total;
        unsigned int lcore_id = 0;
        uint32_t avg_cycles_total;
+       bool dev_stopped = false;
        uint32_t avg_cycles = 0;
        float mops, mops_total;
        float memory = 0;
@@ -943,7 +963,7 @@ mem_copy_benchmark(struct test_configure *cfg)
                    vchan_dev->tdir == RTE_DMA_DIR_MEM_TO_DEV) {
                        if (attach_ext_buffer(vchan_dev, lcores[i], cfg->is_sg,
                                              (nr_sgsrc/nb_workers), 
(nr_sgdst/nb_workers)) < 0)
-                               goto out;
+                               goto stop_dmadev;
                }
 
                if (cfg->is_sg && cfg->use_ops) {
@@ -997,6 +1017,8 @@ mem_copy_benchmark(struct test_configure *cfg)
 
        rte_eal_mp_wait_lcore();
 
+       stop_dmadev(cfg, &dev_stopped);
+
        ret = verify_data(cfg, srcs, dsts, nr_buf);
        if (ret != 0)
                goto out;
@@ -1022,8 +1044,10 @@ mem_copy_benchmark(struct test_configure *cfg)
        output_csv(CSV_TOTAL_LINE_FMT, cfg->scenario_id, nr_buf, memory * 
nb_workers,
                        (avg_cycles_total * (float) 1.0) / nb_workers, 
bandwidth_total, mops_total);
 
-out:
+stop_dmadev:
+       stop_dmadev(cfg, &dev_stopped);
 
+out:
        for (k = 0; k < nb_workers; k++) {
                struct rte_mbuf **sbuf = NULL, **dbuf = NULL;
                vchan_dev = &cfg->dma_config[k].vchan_dev;
@@ -1077,13 +1101,5 @@ mem_copy_benchmark(struct test_configure *cfg)
                lcores[i] = NULL;
        }
 
-       if (cfg->test_type == TEST_TYPE_DMA_MEM_COPY) {
-               for (i = 0; i < nb_workers; i++) {
-                       lcore_dma_map = &cfg->dma_config[i].lcore_dma_map;
-                       printf("Stopping dmadev %d\n", lcore_dma_map->dma_id);
-                       rte_dma_stop(lcore_dma_map->dma_id);
-               }
-       }
-
        return ret;
 }
-- 
2.17.1