Hi > -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Saturday, October 18, 2025 7:23 AM > To: Gagandeep Singh <[email protected]> > Cc: [email protected]; Hemant Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Jun Yang <[email protected]> > Subject: Re: [PATCH v5 5/6] bus/dpaa: Set max push RXQ number > > On Fri, 17 Oct 2025 10:18:47 +0530 > Gagandeep Singh <[email protected]> wrote: > > > > > + /* Disabling the default push mode for LS1043A */ > > + if (rte_dpaa_bus.svr_ver == SVR_LS1043A_FAMILY) { > > + rte_dpaa_bus.max_push_rxq_num = 0; > > + return 0; > > + } > > + > > + penv = getenv("DPAA_PUSH_QUEUES_NUMBER"); > > + if (penv) > > + rte_dpaa_bus.max_push_rxq_num = atoi(penv); > > + if (rte_dpaa_bus.max_push_rxq_num > > DPAA_MAX_PUSH_MODE_QUEUE) > > + rte_dpaa_bus.max_push_rxq_num = > DPAA_MAX_PUSH_MODE_QUEUE; > > Please don't use environment variables for configuration. > We have devargs for that.
We have not introduced any new environment variable, It is just moved to another place.
