From: Vanshika Shukla <[email protected]>

This patch correct the cleanup order of PCD and
FMan handles to prevent resource leaks reported by
coverity tool.

Coverity issue: 362787
Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode")
Cc: [email protected]
Cc: [email protected]

Signed-off-by: Vanshika Shukla <[email protected]>
---
 drivers/net/dpaa/dpaa_flow.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c
index 2a22b23c8f..417b9b6fbb 100644
--- a/drivers/net/dpaa/dpaa_flow.c
+++ b/drivers/net/dpaa/dpaa_flow.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2017-2019,2021-2024 NXP
+ * Copyright 2017-2019,2021-2025 NXP
  */
 
 /* System headers */
@@ -889,9 +889,9 @@ int dpaa_fm_init(void)
        /* FM PCD Enable */
        ret = fm_pcd_enable(pcd_handle);
        if (ret) {
-               fm_close(fman_handle);
-               fm_pcd_close(pcd_handle);
                DPAA_PMD_ERR("fm_pcd_enable: Failed");
+               fm_pcd_close(pcd_handle);
+               fm_close(fman_handle);
                return -1;
        }
 
-- 
2.25.1

Reply via email to