On Thu, 30 Oct 2025 11:20:15 +0200
Gregory Etelson <[email protected]> wrote:
> static char *
> -convert_pci_address_format(const char *identifier, char *pci_buffer, size_t
> buf_size)
> +convert_pci_address_format(const char *identifier, char *pci_buffer)
> {
> struct rte_devargs da;
> struct rte_pci_addr pci_addr;
> @@ -3430,7 +3430,8 @@ convert_pci_address_format(const char *identifier, char
> *pci_buffer, size_t buf_
> if (rte_pci_addr_parse(da.name, &pci_addr) != 0)
> return NULL;
>
> - rte_pci_device_name(&pci_addr, pci_buffer, buf_size);
> + rte_pci_device_name(&pci_addr, pci_buffer, PCI_PRI_STR_SIZE);
> + sprintf(pci_buffer + strlen(pci_buffer), ",%s", da.args);
> return pci_buffer;
> }
It would be safer to keep the buf_size argument. It avoids any overflow issues.
Many tools flag any direct sprintf usage as an error.
