On Mon, Nov 03, 2025 at 03:50:59PM +0000, Medvedkin, Vladimir wrote: > Hi Bruce, thanks for reviewing, will send v2 addressing your comments > > On 11/3/2025 3:10 PM, Bruce Richardson wrote: > > On Mon, Nov 03, 2025 at 03:02:37PM +0000, Vladimir Medvedkin wrote: > > > Add DCB and PFC documentation. Update feature matrix > > > and release notes. > > > > > > Signed-off-by: Vladimir Medvedkin <[email protected]> > > > --- > > > doc/guides/nics/features/ice.ini | 1 + > > > doc/guides/nics/ice.rst | 74 ++++++++++++++++++++++++++ > > > doc/guides/rel_notes/release_25_11.rst | 4 ++ > > > 3 files changed, 79 insertions(+) > > > > > I should have noticed that this was all missing from the original patchset > > and flagged it before merge! Sorry. > > > > Anyway, thanks for doing this now - better late than never, as the saying > > goes! Review comments inline below. > > > > Thanks, > > /Bruce > > > <snip> > > > + > > > +PFC operates in VLAN-based mode and requires DCB to be configured first. > > > + > > So this means you need to call APIs in a specific order? > > Yes, first we need to enable DCB with rte_eth_dev_configure(), then PFC can > be configured on each individual TC. Generally speaking, PFC is a part of > DCB standard so it should be obvious to configure DCB first. >
I wouldn't assume its obvious. Maybe have a combined C-code example in the docs for configuring both. /Bruce
