RE: [PATCH 08/19] net/txgbe: add device arguments for FDIR

[Jiawen Wu]

> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, November 10, 2025 5:29 PM
> To: Jiawen Wu <jiawe...@trustnetic.com>; Jiawen Wu <jiawe...@trustnetic.com>
> Cc: dev@dpdk.org; sta...@dpdk.org; zaiyuw...@trustnetic.com; Stephen 
> Hemminger <step...@networkplumber.org>;
> dev@dpdk.org; sta...@dpdk.org; zaiyuw...@trustnetic.com; Stephen Hemminger 
> <step...@networkplumber.org>
> Subject: Re: [PATCH 08/19] net/txgbe: add device arguments for FDIR
> 
> 27/10/2025 04:15, Jiawen Wu:
> > Since FDIR configuration is deprecated in generic ethdev device
> > configuration and move it into the device private data, there is no way
> > to configure the FDIR parameters.
> >
> > Two device arguments "pkt-filter-size" and "pkt-filter-drop-queue" are
> > added, they just continue to use the previous naming convention.
> >
> > Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director 
> > configuration")
> > Cc: sta...@dpdk.org
> > Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>
> > ---
> >  drivers/net/txgbe/base/txgbe_type.h |  4 ++++
> >  drivers/net/txgbe/txgbe_ethdev.c    | 20 ++++++++++++++++++--
> >  2 files changed, 22 insertions(+), 2 deletions(-)
> 
> You forgot to update the documentation.

I'll add it in v2 set, thanks.