Hi, Please check how to use plain text to send the email? And this is a bug fix, please add fixline and change description of the title line and commit log.
From: Yang Xu <[email protected]> Sent: Monday, August 18, 2025 8:32 AM To: NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Dariusz Sosnowski <[email protected]>; Slava Ovsiienko <[email protected]>; Bing Zhao <[email protected]>; Ori Kam <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad <[email protected]>; [email protected]; [email protected] Cc: [email protected] Subject: [PATCH 1/1] net/mlx5/linux: set down if detect any anomaly External email: Use caution opening links or attachments MLX network interface card link detection will set the interface to a down state upon detecting an anomaly. Signed-off-by: Yang Xu <mailto:[email protected]> --- .mailmap | 1 + drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 34a99f93a1..14d6ee93dd 100644 --- a/.mailmap +++ b/.mailmap @@ -1891,3 +1891,4 @@ Zoltan Kiss <mailto:[email protected]> <mailto:[email protected]> Zorik Machulsky <mailto:[email protected]> Zyta Szpak <mailto:[email protected]> <mailto:[email protected]> Zyta Szpak <mailto:[email protected]> <mailto:[email protected]> +Yang Xu <mailto:[email protected]> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 9daeda5435..364b024b77 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -486,6 +486,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) struct rte_eth_link dev_link; time_t start_time = time(NULL); int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT; + memset(&dev_link, 0, sizeof(dev_link)); // I think the inline initialization = {0} will be faster. do { ret = mlx5_link_update_unlocked_gs(dev, &dev_link); @@ -504,6 +505,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) return -rte_errno; } } else if (ret < 0) { + dev->data->dev_link = dev_link; // Or just set this to 0 directly would save some cost? return ret; } } while (wait_to_complete || retry-- > 0); -- 2.27.0
