On Tue, 25 Nov 2025 11:22:07 +0100 [email protected] wrote: > + if (o_dom_id != dom_id) { > + fprintf(stderr, "Bad shared rxq config: > " > + "switch domain mismatch in > share group/qid %u/%u: " > + "%u (port %u) vs. %u (port > %u)\n", > + (unsigned > int)rxq->conf.share_group, > + (unsigned > int)rxq->conf.share_qid, > + (unsigned int)dom_id, > + (unsigned int)port_id, > + (unsigned int)o_dom_id, > + (unsigned int)pid); > + } else if (o_rx_dom != rx_dom) { > + fprintf(stderr, "Bad shared rxq config: > " > + "switch rx domain mismatch in > share group/qid %u/%u: " > + "%u (port %u) vs. %u (port > %u)\n", > + (unsigned > int)rxq->conf.share_group, > + (unsigned > int)rxq->conf.share_qid, > + (unsigned int)rx_dom, > + (unsigned int)port_id, > + (unsigned int)o_rx_dom, > + (unsigned int)pid); > + }
Same message repeated twice, change the if logic. Also, why so many casts? Those should all be unsigned.
