On Tue, Dec 02, 2025 at 04:53:02PM +0000, Marat Khalili wrote: > > -----Original Message----- > > From: Bruce Richardson <[email protected]> > > Sent: Tuesday 2 December 2025 15:50 > > To: [email protected] > > Cc: Bruce Richardson <[email protected]> > > Subject: [PATCH 2/2] app/test: make parameters clearer when adding fast > > tests > > > > For the fast tests, we have two extra parameters specifying when the > > test can be run without hugepages or using ASan. The true/false nature > > of these parameters is not very clear, so change things so that they are > > explicitly specified as NOHUGE/HUGEPAGES and NOASAN/ASAN instead. > > Explicitly validate the options in the meson.build files, rather than > > just checking for one of the pair of options - which can hide errors. > > I like the idea. However, I think that NOASAN/ASAN is still not fully > self-documenting, and may be misleading. Without reading some docs I'd think > NOASAN means test will be run without sanitizer and ASAN means it will be run > with. As a minimal fix, what about NOHUGE_OK/NOHUGE_SKIP and > ASAN_OK/ASAN_SKIP? >
Ok for those names. Nice and consistent. > More intrusive option, to simplify most normal uses and highlight exceptions: > * 0 (or DEFAULT, or RUN_ALWAYS) > * SKIP_IF_ASAN > * SKIP_IF_NOHUGE > * SKIP_IF_ASAN | SKIP_IF_NOHUGE Yes, that's more intrusive. Not sure it's worth it - I think with the above names things will be a lot clearer. This is also not an API for public consumption, it's just internal flags for meson when configuring the unit tests. Will do a v2 later with the flags renamed as you suggest, unless there is other feedback in the meantime. /Bruce
