> -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Sunday 18 January 2026 20:09 > To: [email protected] > Cc: Stephen Hemminger <[email protected]>; [email protected]; Morten > Brørup > <[email protected]>; Bruce Richardson <[email protected]> > Subject: [PATCH 6/6] test: fix trace_autotest_with_traces parallel execution > > The trace_autotest_with_traces test was reusing the test_args array > from trace_autotest, which already contained --file-prefix=trace_autotest. > > Fix by building trace_args from scratch for the _with_traces test > variant instead of appending to the existing test_args array. > > Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types") > Cc: [email protected] > > Signed-off-by: Stephen Hemminger <[email protected]> > --- > app/test/suites/meson.build | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build > index 38df1cfec2..e62170bebf 100644 > --- a/app/test/suites/meson.build > +++ b/app/test/suites/meson.build > @@ -106,10 +106,18 @@ foreach suite:test_suites > is_parallel : false, > suite : 'fast-tests') > if not is_windows and test_name == 'trace_autotest' > - test_args += ['--trace=.*'] > - test_args += > ['--trace-dir=@0@'.format(meson.current_build_dir())] > + # build separate args list to avoid duplicate --file-prefix > + trace_args = test_no_huge_args > + trace_args += ['--trace=.*'] > + trace_args += > ['--trace-dir=@0@'.format(meson.current_build_dir())] > + if is_linux > + trace_args += > ['--file-prefix=trace_autotest_with_traces'] > + endif > + if get_option('default_library') == 'shared' > + trace_args += ['-d', dpdk_drivers_build_dir] > + endif > test(test_name + '_with_traces', dpdk_test, > - args : test_args, > + args : trace_args, > env: ['DPDK_TEST=' + test_name], > timeout : timeout_seconds_fast, > is_parallel : false, > -- > 2.51.0 >
Instead of duplicating some code and hardcoding values for trace_autotest, which is error-prone, can we make adding file prefix the last thing we do to test_args (perhaps doing it right in the `args : ...` expression) and re-use the previous value and logic like we did it before?
