Hi,
I will try to improve based on this, also some comments inline.
On 23-Jan-26 12:23 AM, Stephen Hemminger wrote:
On Thu, 22 Jan 2026 10:25:33 +0000
Radu Nicolau <[email protected]> wrote:
Add support for
NEA4, NIA4, NCA4: Snow 5G confidentiality, integrity and AEAD modes
NEA5, NIA5, NCA5: AES 256 confidentiality, integrity and AEAD modes
NEA6, NIA6, NCA6: ZUC 256 confidentiality, integrity and AEAD modes
Signed-off-by: Radu Nicolau <[email protected]>
Working on AI based patch review and used this pair as a test case.
The results showed some things (mostly documentation) that could be
fixed and also some false positives like recommending adding __rte_experimental
to enum.
<snip>
## COMPLIANCE SUMMARY
### ✅ Correct
1. **License Headers:** All new files have proper SPDX license identifiers
2. **Copyright:** Intel copyright notices present and properly formatted
3. **C Style:** Code follows DPDK style guidelines (indentation, braces, naming)
4. **Commit Format:** Signed-off-by present, reasonable subject line length
5. **Test Infrastructure:** Proper use of `unit_test_suite_runner` framework
6. **Code Patterns:** No forbidden tokens, no unnecessary casts
### ❌ Must Fix (Errors)
1. Missing release notes update
I have looked prior to send the patches, in the past the additions to
the crypto lib algorithms enums were not captured in the release notes.
2. Missing API stability documentation
The documentation is consistent with all other entries
3. Insufficient commit message detail
Will add technical specifications numbers
### ⚠️ Should Fix (Warnings)
1. Inconsistent algorithm naming
2. Incomplete API documentation
3. Test helper error handling issues
4. Missing cleanup on error paths
5. Magic numbers without constants
6. Memory leak potential in tests
Will review and fix if needed.
### 💡 Consider (Info)
1. Reducing code repetition with macros
2. Improving test vector organization
3. Adding more descriptive error messages
4. Using constants for magic numbers
---
## RECOMMENDATION
**Status:** CHANGES REQUESTED
The patch implements the core functionality correctly and follows most DPDK
conventions. However, it requires:
1. **Mandatory:** Add release notes entry
2. **Mandatory:** Expand commit message with context
3. **Strongly Recommended:** Fix memory leak potential in test helpers
4. **Recommended:** Add comprehensive API documentation
