> > Patch 2: The new queue iteration still doesn't NULL-check the per-queue > > pointer before dereferencing. Given the commit message specifically calls > > out the pointer validity problem, this seems like an oversight. > > Patch 4: rte_zmalloc_socket for a small control structure of file handles > > is using limited hugepage memory unnecessarily — plain calloc would suffice. > > Patch 4 raises a good point, file handles are per-process so doesn't need to > be in hugepages.
I'll keep that in mind for future changes. > Not sure about comment about Patch #2. The queues are set to null on close. > So there might be small race with another process getting stats. Oh, I see. The original problem (described in the commit message) has been solved, but in the case you described, checking for null is still not enough and some rte_spinlock_lock should also be used.
