Hi Stephen,

Thanks for the comments. What do you mean by missing release notes? Should I 
add some description of the new conversion type? It will not break the current 
usage of any user.
So do you mean I should let the user know that they can do the inline 
calculation with the new API?

Thanks

> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Tuesday, November 18, 2025 1:25 AM
> To: Bing Zhao <[email protected]>
> Cc: Slava Ovsiienko <[email protected]>; [email protected]; Raslan
> Darawsheh <[email protected]>; Ori Kam <[email protected]>; Dariusz
> Sosnowski <[email protected]>; Suanming Mou <[email protected]>;
> Matan Azrad <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <[email protected]>
> Subject: Re: [PATCH 1/2] lib/ethdev: support inline calculating masked
> item value
> 
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 17 Nov 2025 09:54:07 +0200
> Bing Zhao <[email protected]> wrote:
> 
> > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index
> > fe8f43caff..b94f0e304d 100644
> > --- a/lib/ethdev/rte_flow.c
> > +++ b/lib/ethdev/rte_flow.c
> > @@ -831,6 +831,8 @@ rte_flow_conv_action_conf(void *buf, const size_t
> size,
> >   *   RTE_FLOW_ITEM_TYPE_END is encountered.
> >   * @param[out] error
> >   *   Perform verbose error reporting if not NULL.
> > + * @param[in] with_mask
> > + *   If true, @p src mask will be applied to spec and last.
> >   *
> >   * @return
> >   *   A positive value representing the number of bytes needed to store
> 
> Sorry, this patch is submitted too late to make it into 25.11 release.
> Missing any release note.
> 
> This would be a good example of where to use API versioning in a later
> release.

Reply via email to