Hi,
On 12/01/2026 7:23 PM, Dariusz Sosnowski wrote:
From: Xiaoyu Min <[email protected]> There are a couple of issues in the logic used by counter service thread to refresh flow counter values in HW Steering mode: 1. Flow counter offset in bulk is not taken into account correctly during query. 2. Number of WQEs used up during query is not tracked correctly. Regarding the 1st issue, HW flow counters are queried by posting WQEs. Each WQE queries 4 flow counters at once. Flow counters are addressed by base ID (ASO object ID) and offset (divided by 4). During periodic counter refresh, mlx5 PMD fills whole queue with WQEs and waits for query completion. This is repeated until all known counters are refreshed. The issue is that, between different iterations the base offset was not adjusted. This lead to the same 64k counters (max achievable through single queue) were being queried. Any flow counters above that limit would get incorrect values. This patch addresses that by adding proper offset calculation during query loop. Regarding the 2nd issue, tracking of how many counters were really queried during single loop was incorrect. In case when there weren't enough free WQEs in the queue, fewer counters were queried than expected. This mismatch was not taken into account, which in the resulted in some counters not being queried. This patch addresses that by adding proper reporting of the number of queried counters to mlx5_aso_cnt_sq_enqueue_burst(). Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Cc: [email protected] Reported-by: Mohand Alrasheed <[email protected]> Signed-off-by: Xiaoyu Min <[email protected]> Acked-by: Dariusz Sosnowski <[email protected]>
Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh
