On Fri, 6 Feb 2026 17:20:54 +0000
Kevin Traynor <[email protected]> wrote:
> Add handling for epoll error and disconnect conditions EPOLLERR,
> EPOLLHUP and EPOLLRDHUP.
>
> These events indicate that the interrupt file descriptor is in
> an error state or there has been a hangup.
>
> Only do this for interrupts that are read in eal. Interrupts that
> are read outside eal should deal with different interrupt scenarios
> appropriate to their functionality. e.g. virtio interrupt handling
> has reconnect mechanisms for some cases.
>
> Also, treat no bytes read as an error condition.
>
> Bugzilla ID: 1873
> Fixes: af75078fece3 ("first public release")
> Cc: [email protected]
>
> Signed-off-by: Kevin Traynor <[email protected]>
Minor AI review nits.
Code Review
Errors:
Lines 295-298: Block comment uses incorrect style Same issue as patch 1 -
should use /* not /** for non-documentation comments.
Warnings:
Line 304: Return value inconsistency The function returns -1 to force
rebuild of the wait list, but this happens in the middle of processing multiple
events. The existing code had the same pattern for error handling, so this is
consistent with the codebase style.
Line 342: Log level changed from ERR to WARNING For a condition that causes
interrupt source removal, WARNING may be too low. Consider if INFO (as used in
line 300) might be more appropriate for consistency.
Overall Assessment
Both patches address a real bug (busy-looping on interrupt errors) with
reasonable solutions. The main issues are code style violations with comment
formatting and a minor semicolon error. The logic appears sound for handling
the EAGAIN and epoll error conditions.
