On Mon, 16 Feb 2026 11:01:34 +0100 David Marchand <[email protected]> wrote:
> On Fri, 13 Feb 2026 at 20:21, Stephen Hemminger > <[email protected]> wrote: > > > > If null PMD is disabled in the build via -Ddisable_drivers=null > > then do not build pcapng test. > > > > Fixes: 6f01a3ca5c7f ("test: fix dependency on pcapng") > > There was no dependency on net/null at this point in git history. > Instead, this fix is about: > Fixes: 0c614a0fa6c6 ("test/pcapng: cleanup") > > > > Cc: [email protected] > > > > Signed-off-by: Stephen Hemminger <[email protected]> > > The point is if the null driver is disabled the test would always fail. The commit log is incorrect, the flag would be -Ddisable_drivers=net/null Seemed better to just not build the test if the driver isn't there. Alternative is to detect it and marked as SKIPPED. But vdev_init error codes are very broad, and my preference is to save space/time. # DPDK_TEST=pcapng_autotest ./build/app/dpdk-test --no-huge -m 2048 EAL: Detected CPU lcores: 32 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' APP: HPET is not enabled, using TSC as default timer RTE>>pcapng_autotest + ------------------------------------------------------- + + Test Suite : Test Pcapng Unit Test Suite Failed to create vdev 'net_null0'
