The implementation of the patch looks good to me, but I think the testsuites being reduced from 2 links to 1 link might be an incorrect set.
For instance, I just did a testrun on cx7 comparing for-main to for-main + this series. This series introduces failures for: port control: start_ports testcase vlan: vlan_no_receipt testcase vlan: vlan_receipt_stripping testcase In terms of why these fails are happening... in principle the functions flexed by these testcases should be fine to test with 1 link. My guess is we are uncovering an issue with the scapy sniffer when running a 1 link test. The port_control testcase fails because it expects 100 packets and sniffs 200. Perhaps this is because it is sniffing both tx and rx packets on the TG port 0. We have code to prevent this from the most recent implementation of the sniffer class but maybe it has a gap.
