On Mon, 23 Mar 2026 11:52:59 +0100 David Marchand <[email protected]> wrote:
> Each bus reimplements some similar devargs lookup code. > > The differences are in how some bus (PCI, VMBUS etc...) normalizes the > device names. We can't use the .parse existing handler from outside the > bus code itself, as the size of the bus specific device location address > is unknown. > Introduce a bus specific helper to compare two device names and > hide this ugly detail. > > Signed-off-by: David Marchand <[email protected]> > Acked-by: Bruce Richardson <[email protected]> > --- > Changes since RFC v3: > - fixed doxygen, > > --- More AI review: Patch 5/8: bus: factorize devargs lookup Warning: The Doxygen for rte_bus_find_devargs() in bus_driver.h describes the bus parameter as "A pointer to a rte_bus structure describing the bus to be unregistered" -- this is copy-pasted from rte_bus_unregister. Should say something like "the bus to search for devargs on." Warning: The Doxygen for rte_bus_devname_compare_t has two issues: the @return says "true or false" but the function follows strcmp semantics (0 for match, non-zero for no match), and the @param descriptions both say "device information location address" when they should say "device name string."
