Add missing verbose log of FW errors when modifying SQ and RQ.
Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure")
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Dariusz Sosnowski <[email protected]>
Acked-by: Viacheslav Ovsiienko <[email protected]>
---
drivers/common/mlx5/mlx5_devx_cmds.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c
b/drivers/common/mlx5/mlx5_devx_cmds.c
index d12ebf8487..d46aa045df 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -1672,13 +1672,11 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
}
ret = mlx5_glue->devx_obj_modify(rq->obj, in, sizeof(in),
out, sizeof(out));
-
- if (ret) {
- DRV_LOG(ERR, "Failed to modify RQ using DevX");
- rte_errno = errno;
- return -errno;
+ if (ret || MLX5_FW_STATUS(out)) {
+ DEVX_DRV_LOG(ERR, out, "RQ modify", "rq_id", rq->id);
+ return MLX5_DEVX_ERR_RC(ret);
}
- return ret;
+ return 0;
}
/*
@@ -2116,12 +2114,11 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
MLX5_SET(sqc, sq_ctx, hairpin_peer_vhca, sq_attr->hairpin_peer_vhca);
ret = mlx5_glue->devx_obj_modify(sq->obj, in, sizeof(in),
out, sizeof(out));
- if (ret) {
- DRV_LOG(ERR, "Failed to modify SQ using DevX");
- rte_errno = errno;
- return -rte_errno;
+ if (ret || MLX5_FW_STATUS(out)) {
+ DEVX_DRV_LOG(ERR, out, "SQ modify", "sq_id", sq->id);
+ return MLX5_DEVX_ERR_RC(ret);
}
- return ret;
+ return 0;
}
/*
--
2.47.3
