RE: [PATCH v2 1/2] app/testpmd: assign share group dynamically

[Dariusz Sosnowski]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Wednesday, March 25, 2026 5:51 PM
> To: Dariusz Sosnowski <dsosnow...@nvidia.com>
> Cc: Aman Singh <aman.deep.si...@intel.com>; dev@dpdk.org; NBU-
> Contact-Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; Raslan
> Darawsheh <rasl...@nvidia.com>; Adrian Schollmeyer
> <a.schollme...@syseleven.de>
> Subject: Re: [PATCH v2 1/2] app/testpmd: assign share group dynamically
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 24 Mar 2026 17:56:56 +0100
> Dariusz Sosnowski <dsosnow...@nvidia.com> wrote:
> 
> > +     /*
> > +      * testpmd assigns all queues on a given port to single share group.
> > +      * There are RTE_MAX_ETHPORTS share group slots,
> > +      * so at least one should always be available.
> > +      */
> > +     RTE_ASSERT(first_free < RTE_DIM(share_group_slots));
> > +
> 
> Since RTE_ASSERT is compiled away in normal builds, this is a noop.
> Please use a regular if statement and error handling.

Fixed in v3.

Best regards,
Dariusz Sosnowski