On Wed, Apr 01, 2026 at 09:40:22AM -0700, Stephen Hemminger wrote:
> No need to check for null before calling free.
> Found by coccinelle script null_free.
> 
> Signed-off-by: Stephen Hemminger <[email protected]>
> ---
>  drivers/net/intel/ice/ice_dcf_sched.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
Acked-by: Bruce Richardson <[email protected]>


> diff --git a/drivers/net/intel/ice/ice_dcf_sched.c 
> b/drivers/net/intel/ice/ice_dcf_sched.c
> index 948774a282..14e902edbe 100644
> --- a/drivers/net/intel/ice/ice_dcf_sched.c
> +++ b/drivers/net/intel/ice/ice_dcf_sched.c
> @@ -877,10 +877,8 @@ static int ice_dcf_hierarchy_commit(struct rte_eth_dev 
> *dev,
>       return ret_val;
>  
>  fail_clear:
> -     if (vf_bw != NULL)
> -             free(vf_bw);
> -     if (tc_bw != NULL)
> -             free(tc_bw);
> +     free(vf_bw);
> +     free(tc_bw);
>  
>       /* clear all the traffic manager configuration */
>       if (clear_on_fail) {
> -- 
> 2.53.0
> 

Reply via email to