Remove four redundant counters (tx_xon_packets, rx_xon_packets,
tx_xoff_packets and rx_xoff_packets) from xstats, as they were duplicates
of tx_flow_control_xon_packets and others. Both sets were reading the same
registers but being output twice under different names. After removing
these entries, the flow control counters in DPDK now align with those in
our Linux kernel driver.

Fixes: 91fe49c87d76 ("net/txgbe: support device xstats")
Cc: [email protected]

Signed-off-by: Zaiyu Wang <[email protected]>
---
 drivers/net/txgbe/txgbe_ethdev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 5d360f8305..779874aac9 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -261,11 +261,6 @@ static const struct rte_txgbe_xstats_name_off 
rte_txgbe_stats_strings[] = {
        HW_XSTAT(tx_size_1024_to_max_packets),
 
        /* Flow Control */
-       HW_XSTAT(tx_xon_packets),
-       HW_XSTAT(rx_xon_packets),
-       HW_XSTAT(tx_xoff_packets),
-       HW_XSTAT(rx_xoff_packets),
-
        HW_XSTAT_NAME(tx_xon_packets, "tx_flow_control_xon_packets"),
        HW_XSTAT_NAME(rx_xon_packets, "rx_flow_control_xon_packets"),
        HW_XSTAT_NAME(tx_xoff_packets, "tx_flow_control_xoff_packets"),
-- 
2.21.0.windows.1

Reply via email to