[RFC v2 10/11] net/sfc: replace rte_atomic with stdatomic

[Stephen Hemminger]

The rte_atomicNN functions are deprecated and need to be replaced.
Use stdatomic for the restart required flag.
Use existing ethdev helper to set link status.

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 drivers/net/sfc/sfc.c       | 9 +++++----
 drivers/net/sfc/sfc.h       | 4 ++--
 drivers/net/sfc/sfc_port.c  | 7 +------
 drivers/net/sfc/sfc_stats.h | 2 +-
 4 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c
index 69747e49ae..3470f7eed6 100644
--- a/drivers/net/sfc/sfc.c
+++ b/drivers/net/sfc/sfc.c
@@ -670,8 +670,8 @@ sfc_restart_if_required(void *arg)
        struct sfc_adapter *sa = arg;
 
        /* If restart is scheduled, clear the flag and do it */
-       if (rte_atomic32_cmpset((volatile uint32_t *)&sa->restart_required,
-                               1, 0)) {
+       if (rte_atomic_exchange_explicit(&sa->restart_required, false,
+                                        rte_memory_order_seq_cst)) {
                sfc_adapter_lock(sa);
                if (sa->state == SFC_ETHDEV_STARTED)
                        (void)sfc_restart(sa);
@@ -685,7 +685,8 @@ sfc_schedule_restart(struct sfc_adapter *sa)
        int rc;
 
        /* Schedule restart alarm if it is not scheduled yet */
-       if (!rte_atomic32_test_and_set(&sa->restart_required))
+       if (rte_atomic_exchange_explicit(&sa->restart_required, true,
+                                        rte_memory_order_seq_cst))
                return;
 
        rc = rte_eal_alarm_set(1, sfc_restart_if_required, sa);
@@ -1292,7 +1293,7 @@ sfc_probe(struct sfc_adapter *sa)
        SFC_ASSERT(sfc_adapter_is_locked(sa));
 
        sa->socket_id = rte_socket_id();
-       rte_atomic32_init(&sa->restart_required);
+       sa->restart_required = false;
 
        sfc_log_init(sa, "get family");
        rc = sfc_efx_family(pci_dev, &mem_ebrp, &sa->family);
diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h
index 629578549f..515e1e708d 100644
--- a/drivers/net/sfc/sfc.h
+++ b/drivers/net/sfc/sfc.h
@@ -17,7 +17,7 @@
 #include <ethdev_driver.h>
 #include <rte_kvargs.h>
 #include <rte_spinlock.h>
-#include <rte_atomic.h>
+#include <rte_stdatomic.h>
 
 #include "efx.h"
 
@@ -239,7 +239,7 @@ struct sfc_adapter {
        efx_family_t                    family;
        efx_nic_t                       *nic;
        rte_spinlock_t                  nic_lock;
-       rte_atomic32_t                  restart_required;
+       RTE_ATOMIC(bool)                restart_required;
 
        struct sfc_efx_mcdi             mcdi;
        struct sfc_sriov                sriov;
diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c
index 33b53f7ac8..d84648d454 100644
--- a/drivers/net/sfc/sfc_port.c
+++ b/drivers/net/sfc/sfc_port.c
@@ -121,7 +121,6 @@ sfc_port_reset_mac_stats(struct sfc_adapter *sa)
 static int
 sfc_port_init_dev_link(struct sfc_adapter *sa)
 {
-       struct rte_eth_link *dev_link = &sa->eth_dev->data->dev_link;
        int rc;
        efx_link_mode_t link_mode;
        struct rte_eth_link current_link;
@@ -132,11 +131,7 @@ sfc_port_init_dev_link(struct sfc_adapter *sa)
 
        sfc_port_link_mode_to_info(link_mode, sa->port.phy_adv_cap,
                                   &current_link);
-
-       EFX_STATIC_ASSERT(sizeof(*dev_link) == sizeof(rte_atomic64_t));
-       rte_atomic64_set((rte_atomic64_t *)dev_link,
-                        *(uint64_t *)&current_link);
-
+       rte_eth_linkstatus_set(sa->eth_dev, &current_link);
        return 0;
 }
 
diff --git a/drivers/net/sfc/sfc_stats.h b/drivers/net/sfc/sfc_stats.h
index 597e14dab3..eaa2afd3fe 100644
--- a/drivers/net/sfc/sfc_stats.h
+++ b/drivers/net/sfc/sfc_stats.h
@@ -12,7 +12,7 @@
 
 #include <stdint.h>
 
-#include <rte_atomic.h>
+#include <rte_stdatomic.h>
 
 #include "sfc_tweak.h"
 
-- 
2.53.0