Hello, On Fri, 22 May 2026 at 03:05, fengchengwen <[email protected]> wrote: > >> { > >> + bool forward_compat = !!(dr->drv_flags & > >> RTE_UACCE_DRV_FORWARD_COMPATIBILITY_DEV); > >> + uint32_t api_ver = uacce_calc_api_ver(dev->api, NULL); > > > > This conversion from a string to integer could be placed in the scanning > > step. > > Why place it here? > > I think it's OK to place in the scanning step. > Should I submit a commit to fix this?
Let me handle it. I'll post a new revision of the series with a fix soon. > > The dev->api_ver has no in-tree user. > > This field was (silently?) dropped by my best AI friend in the bus > > refactoring series I posted. > > https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ > > > > Please advise if I can drop this field (it is just the integer value > > extracted from dev->api afaiu), or if it should be moved to the > > scanning step. > > Please keep this field. > This field mainly used for driver to know which api-version the device > support, so driver could do > bug-fix for specific device by judging this field. I am not a fan of leaving unused stuff, for a potential future case where it could (maybe) be needed. This is your bus and drivers, and the change is simple enough, so ok, no strong objection from me. Thanks for the reply (and sorry for not replying sooner, I was out for some days). -- David Marchand
