Hi Patrick, Thanks for the review
> I don't understand the change above. Surely we do want to set the custom > meson args for ICE DUTs when there is a sut_port_ingress, not when there > isn't a sut_port_ingress, right? > > Yes, this was something I overlooked and will be updated in the next patch. > Also, does the topology type affect whether we want to use these custom > args, if the SUT driver is ice? I guess in a weird case we could have an > ethdev test using an ice DUT which does not need a TG? > > My understanding is that if the link topology is no link, there will be no ingress and the ports on the NIC would not be used for traffic. I do not believe this argument will still be required if no traffic is being handled. Please let me know if you disagree with this approach or if I am missing something.
